MultiServer: allow underscore as space replacement

[Berserker66]

What is this fixing or adding?

requests such as https://discord.com/channels/731205301247803413/1238036062346149909

How was this tested?

with a few commands, such as

/alias Test_potato Berserker
Named Test Potato as Berserker
/send tEsT_potato Progressive Dots
Notice (all): Cheat console: sending "Progressive Dots" to Berserker (Test Potato)

[PinkSwitch]

Will this break if a user has an actual underscore in their name? What about if there are 2 players: test_potato and test potato ?

[ScipioWright]

Will this break if a user has an actual underscore in their name? What about if there are 2 players: test_potato and test potato ?

I think I would be fine with not allowing two players to have the same name where the only difference is one has an underscore where the other has a space

[Berserker66]

This is already addressed, you cannot have this.

[black-sliver]

You think this is better than trying to fix clients and command parsing to properly allow both spaces and underscores everywhere? Encapsulating string with spaces in " quotes is something even less tech-savvy people understand as far is i know. And we can provide command line documentation/recommendations in Network API so individual clients behave similar.

I won't block this, but I'll let the community decide (i.e. wait for enough peer review approvals before I hit approve).

[Berserker66]

This is a relatively simple and easy change we can do now, a proper command parser that understands " everywhere I'd say is still desirable and may eventually replace this.

[black-sliver]

Note sure if you want to fix this, but this should probably be a separate test for readability.

[black-sliver]

I'm wondering if it would be cheaper to do " " -> "_" rather than "_" -> " " because during runtime we will see more "_" than " ", but it shouldn't matter much.