Spelunker: Implement New Game #3282
Open
+1,422
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
reviewed
May 9, 2024
| return | ||
| if "tags" not in args: | ||
| return | ||
| if "DeathLink" in args["tags"] and args["data"]["source"] != ctx.slot_info[ctx.slot].name: |
There was a problem hiding this comment.
This means that two players playing on the same slot won't send deathlinks to each other. If you don't care about supporting that, don't worry about it.
There was a problem hiding this comment.
I'll have to think on this one.
Exempt-Medic
added
the
is: new game
Co-authored-by: Bryce Wilson <gyroscope15@gmail.com>
ScipioWright
reviewed
May 9, 2024
| option_cave_3 = 2 | ||
| option_cave_4 = 3 | ||
| default = 0 | ||
|
|
There was a problem hiding this comment.
Would recommend adding StartInventoryPool here too.
Add StartInventoryPool to your imports from Options, then put start_inventory_from_pool: StartInventoryPool in your options dataclass.
|
Oh yeah, also update CODEOWNERS and the AP README |
|
I’ll address all these tonight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Implements 'Spelunker' for the NES into AP.
How was this tested?
Technically hasn't been run publicly yet, but I've done personal tests to make sure everything is working, and given how long it takes for PRs to get reviewed, I'm sure if any issues come up I'll be able to fix them while reviews come on. Overall, the world is very small so I don't expect there to be too many problems, if any, and I've already caught the major ones that I've found.
If this makes graphical changes, please attach screenshots.
Sprites courtesy of Seafo
Author's Note:
tis a silly game, made a micro apworld in a 3 day timespan lol