Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Accessibility: Backport modal autofocus in latest insomnia version #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thgcode
Copy link

@thgcode thgcode commented Mar 27, 2024

This pull request backports Pull request 6945 on Insomnia. This pull request adds a focus scope to the modals and autofocuses it, making a screen reader (for example NVDA) moving the cursor inside of the modal and speaking its contents automatically, instead of requiring the user to guess if the modal was opened and manually moving the keyboard to it.

Tests performed:

With the code on the main branch:

  • With NVDA active, opened insomnium and pressed CTRL+, to open the preferences window.
    NVDA does not identified the modal, requiring the user to press CTRL+HOME and space to open id, the arrow keys caused NVDA to speak other elements not related with the modal.

With the code on this pull request:

  • With NVDA active, opened Insomnium and pressed CTRL+, to open the preferences window.
    NVDA instantly started to speak the modal contents and the arrow keys worked to speak the modal elements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant