Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain cycling issues fixed #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Adiletkozha
Copy link

  1. There was retain cycle in line inside PlayerSlider.swift:
    issue:var delegate: PlayerSliderProtocol?
    fix: weak delegate: PlayerSliderProtocol?
  2. Problem also related to retain cycles inside block which is inside prefetchItems function within PandoraPlayer.swift
    issue: item = DispatchWorkItem(block: {
    fix: item = DispatchWorkItem(block: {[unowned self] in
  3. targetColumn value inside CenterCellCollectionViewFlowLayout had been computing incorrectly
    issue: let targetColumn = floor(proposedContentOffset.x/w + 1)
    fix: let targetColumn = floor(proposedContentOffset.x/(w+self.minimumLineSpacing) + 1)

@Adiletkozha Adiletkozha changed the title Ad fix branch Retain cycling issues fixed Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant