Fix arithmetic overflow at all default reservoir #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for helping out 馃憤
Before submitting a pull request, please have a quick read through the contribution guidelines and provide the following information, where appropriate replace the
[ ]
with a[X]
The issue or feature being addressed
DefaultAlgorithmRReservoir
. Same problem exists for other reservoirs.During snapshot creation array of UserValueWrappers will be created with negative size, thus resulting into OverflowException.
Now during casting total count to int it will be always lower than int.MaxValue, because it is compared to value's size.
Details on the issue fix or feature implementation
ReservoirBase
with fixed problem.DefaultXXXReservoir
now inherited fromReservoirBase
ReservoirBase
so simple refactored allDefaultXXXReservoir
Confirm the following