Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NRE in MetricsTags' GetHashCode #751

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix NRE in MetricsTags' GetHashCode #751

wants to merge 1 commit into from

Conversation

sunsided
Copy link

@sunsided sunsided commented Feb 18, 2023 •
edited

The issue or feature being addressed

This fixes #703: A typo in MetricTags.GetHashCode results in a NRE regardless of whether _key or _keys is set.

Details on the issue fix or feature implementation

I changed the test from _key == null to _keys == null which appears to be what was originally intended.

Confirm the following

  • I have ensured that I have merged the latest changes from the dev branch
  • I have successfully run a local build
  • I have included unit tests for the issue/feature
  • I have included the github issue number in my commits

@sunsided sunsided mentioned this pull request Feb 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sunsided