Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #637 "Add metric description" implementation #728

Open
wants to merge 4 commits into
base: features/4.4.0
Choose a base branch
from

Conversation

aivanov-oneinc
Copy link

@aivanov-oneinc aivanov-oneinc commented Feb 23, 2022

Suggestion to resolve #637

Details on the issue fix or feature implementation

I saw in the protobuf contracts for Prometheus the help field exists and is even written to the output, but in the Options classes for all metrics it is absent. So I decided that I can add the "Description" property to the Options and init its value with Options of the appropriate metric.

Also, I've added unit tests that check how the output formatting looks.

Also, I've fixed the small issues with the Prometheus sandbox app

Confirm the following

  • I have ensured that I have merged the latest changes from the dev branch
  • I have successfully run a local build
  • I have included unit tests for the issue/feature
  • I have included the github issue number in my commits

@aivanov-oneinc aivanov-oneinc changed the title Issues 637 "Add metric description" implementation Issues #637 "Add metric description" implementation Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Description option [feature request]
1 participant