Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Description option [feature request] #637

Open
guffy1234 opened this issue Jan 14, 2021 · 1 comment · May be fixed by #728
Open

Add Description option [feature request] #637

guffy1234 opened this issue Jan 14, 2021 · 1 comment · May be fixed by #728

Comments

@guffy1234
Copy link

guffy1234 commented Jan 14, 2021 •
edited

hi

It would be nice to add Description string property to MetricValueOptionsBase and use it as "help" value for Prometheus MetricFamily
@ivonask
Copy link

ivonask commented Jul 13, 2021

+1

aivanov-oneinc added a commit to aivanov-oneinc/AppMetrics that referenced this issue Feb 23, 2022
@aivanov-oneinc
AppMetrics#637 add Description property for the metric
7d2abcd
aivanov-oneinc added a commit to aivanov-oneinc/AppMetrics that referenced this issue Feb 23, 2022
@aivanov-oneinc
AppMetrics#637 extend extension methods
3c0064c
aivanov-oneinc added a commit to aivanov-oneinc/AppMetrics that referenced this issue Feb 23, 2022
@aivanov-oneinc
AppMetrics#637 Copy settings file in sandbox app
2499c57
aivanov-oneinc added a commit to aivanov-oneinc/AppMetrics that referenced this issue Feb 23, 2022
@aivanov-oneinc
AppMetrics#637 add unit tests
254a748 
Add unit tests that check that desciption field is appeared in text formatted output
@aivanov-oneinc aivanov-oneinc linked a pull request Feb 23, 2022 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues #637 "Add metric description" implementation aivanov-oneinc/AppMetrics
2 participants
@ivonask @guffy1234