Handle the case with subdirs in usr/lib64. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think we should generalize this a bit to also work on 32-bit and on Debian/Ubuntu-style filesystem hierarchies. |
|
Unfortunately, I have no clue what is the directory structure on Debian/Ubuntu inside /usr/lib64 and whether it is the case for them. |
|
Hi, I haven't checked this for a while, is this still actual? Could I just close it? |
|
HI @crayxt it looks like no one has looked deeper into this so far. So let's keep it open as a reminder. |
|
@probonopd Hi, I am just doing housekeeping on Github issues I raised. I closed several. If any of them is still actual, let's keep them open. Thanks! |
|
Thanks for checking, very mindful of you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen it on Centos 7-based appimage builds, when there are /usr/lib64/pulseaudio, /usr/lib64/samba and such, and those paths are not in LD_LIBRARY_PATH of appimage. As suggested, moving all those libraries from subdirs of usr/lib64 into usr/lib64 itself, and delete those subdirs.
I have tested it only on Centos 7-based appimage build.
Please review, thanks!