Clear input value #35
Conversation
|
@slauzinho good idea, but your input is surely already control from your side. And not everyone want this behavior I think. Maybe I can add a boolean option where this can do both. What you think? |
|
Sounds good to me, I can do it for you if you want. Should I add it as a prop of the component or a param for the |
|
I think the component is best, but I'm open to anything |
| @@ -39,7 +39,12 @@ export interface DefaultProps { | |||
| minLength: number; | |||
| debounce: number; | |||
| language: string; | |||
| queryTypes: 'address' | 'geocode' | 'cities' | 'establishment' | 'geocode|establishment'; | |||
| queryTypes: | |||
There was a problem hiding this comment.
I dont think this change is need can you rollback this one
There was a problem hiding this comment.
Will work on submitting an updated PR this weekend
|
@slauzinho did you forget about this? |
|
what happened to this change? Any news? It would be great to have that boolean as a parameter to clearSearch....really handy |
Can we also clear the input value if we call
clearSearchsince it implies that we are clearing the search input.