Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in operation (1-Tan(x)^2)*Tan(2*x) #6

Open
3 of 4 tasks
Antonio-JP opened this issue Mar 16, 2021 · 3 comments · May be fixed by #15
Open
3 of 4 tasks

Error in operation (1-Tan(x)^2)*Tan(2*x) #6

Antonio-JP opened this issue Mar 16, 2021 · 3 comments · May be fixed by #15
Assignees
@Antonio-JP
Labels
bug Something isn't working
Milestone
Release version 1.0

Comments

@Antonio-JP
Copy link
Owner

Antonio-JP commented Mar 16, 2021 •
edited

Reported an error by Veronika while computing (1-Tan(x)^2)*Tan(2*x). While checking the error, the two factors can be built easily and fast. However, the computation of the final product takes longer.
After some minutes of computing, the following output is given:
TypeError: unsupported operand type(s) for *: 'DDFunction' and 'DDFunction'

When I reproduced the error, it took a long time and the error raised.

We need to check:

  • Does the error ocur in the current version?
  • How long does it take?
  • Investigate the reason
  • Solve it
@Antonio-JP Antonio-JP added the bug Something isn't working label Mar 16, 2021
@Antonio-JP Antonio-JP self-assigned this Mar 16, 2021
@Antonio-JP
Copy link
Owner Author

The error is a problem when casting an element to the lazy ring:
Check this line: lazyRing.py(543)

@Antonio-JP Antonio-JP changed the title Error in operation (1-Tan(x)^2)*Tan(2*x) #5: Error in operation (1-Tan(x)^2)*Tan(2*x) Jul 12, 2021
@Antonio-JP Antonio-JP changed the title #5: Error in operation (1-Tan(x)^2)*Tan(2*x) Error in operation (1-Tan(x)^2)*Tan(2*x) Jul 12, 2021
@Antonio-JP
Copy link
Owner Author

Found that the error was converting a huge polynomial as a lazy element. The original code did the casting transforming the polynomial into a string and then using the constructor of the PolynomialRing.
This was used to avoid the treatment of different number of variables between the original polynomial ring and the destiny polynomial ring. Theoretically, this casting is always valid, but for Sage, this may not be the case.

The remaining issue is to check that the original example runs properly. (It takes too long)

@Antonio-JP Antonio-JP added this to the Release version 1.0 milestone Aug 9, 2021
@Antonio-JP
Copy link
Owner Author

Worked on branch fix_#6

@Antonio-JP Antonio-JP linked a pull request Aug 11, 2021 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Antonio-JP Antonio-JP

Labels
bug Something isn't working
Projects
None yet
Milestone
Release version 1.0
Development

Successfully merging a pull request may close this issue.

Fixing the issue #6 Antonio-JP/dd_functions
1 participant
@Antonio-JP