Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collection and ads shortlink #288

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

keunes
Copy link
Member

@keunes keunes commented Nov 23, 2023

No description provided.

@keunes
Copy link
Member Author

keunes commented Nov 23, 2023

Hi @Rotzbua,

Could I call on your help here? I want to turn the shortlinks into a collection, so we can

  • set default frontmatter for the entities, and
  • create a shortlinks 'index' page (so I can see which shortlinks we have, when replying to Play store reviews)

Envisioned approach: https://github.com/AntennaPod/antennapod.github.io/pull/287/files

I created the collection, and I'm using the redirect layout file, which is already used for the 'manually' created pages. The issue seems to be in _includes/head.html, because removing this include from _layouts/redirect.html solves the issue - it builds successfully. For some reason, there is a null string somewhere. As you can see from the commit history, I tried to find the source of the problem - unfortunately to no avail.

Annoyingly, the site builds with no problem at all locally on my machine (I have different versions than what GitHub uses). So it's hard to get relevant debug information.

Do you have issues building the current state locally? Any idea why we're ending up with a null string somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant