Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite refresh indicator #7137

Merged

Conversation

flofriday
Copy link
Contributor

Description

Closes: #7136

Before when refreshing any feed(s) without network the refresh indicator stayed indefinitely.

This was also the case if you were on mobile, trying to refresh a need and in the popup selected "don't update over mobile".

Checklist

Notes

I am not completely sure if this is how the fix should be implemented, maybe there is a cleaner version.

Before when refreshing any feed(s) without network the refresh indicator
stayed indefinitely.

This was also the case if you were on mobile, trying to refresh a need
and in the popup selected "don't update over mobile".
@ByteHamster ByteHamster merged commit 4cf3623 into AntennaPod:develop Apr 25, 2024
6 checks passed
@ByteHamster
Copy link
Member

Thanks for contributing so many nice changes!

Will be released in AntennaPod 3.5.x

@flofriday
Copy link
Contributor Author

Sure, thanks for the feedback.
Should I keep making issues for even relative small bug fixes? Like for now I did it because that's how it is written in the PR template that there should be a matching issue.

@ByteHamster
Copy link
Member

With the issues we want to avoid that someone spends time working on something that we later don't merge. (one example would be people updating dependencies, which needs a lot of testing - not just changing the version numbers. Another example would be adding prominent new buttons to screens to access something "in one click" - while that might help that one user, it clutters the screen for everyone else. So we need to discuss stuff like that first)

If you are working on obvious bug fixes, you don't need to create an issue :)

@flofriday
Copy link
Contributor Author

Makes sense, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite update indicator when refresh without network
2 participants