Implement missing equals and hashcode methods for feeditem

[flofriday]

Description

Closes: #7108

The episodes were never removed from the Queue screen or the queue segment on the homescreen because no QueueEventwas emitted.

However, after closer inspection I found that there was already code in DBWriter to remove all such items:

AntennaPod/storage/database/src/main/java/de/danoeh/antennapod/storage/database/DBWriter.java

Line 197 in c56facd

private static void deleteFeedItemsSynchronous(@NonNull Context context, @NonNull List<FeedItem> items) {

With more debugging I discovered that the queue.remove always returned false and never removed any items even if they were structurally equal. Since FeedItem doesn't override equal the two identical items are only equal if they are the same instance which is here never the case and therefore this never finds the matching items in the queue.

By adding the equals method the bug is fixed as the code now works as intended.

Questions:
I implemented equals by just comparing the feedid and id of the item. This is mostly cause I don't want to cyclic equals where a feeditem defines equals with it's feed and the feed with all the items it holds. However, I am not sure if the assumption is save to make that two FeedItems are always equal if those two id's match so maybe someone with more experience can verify that.

Also while we're at it should we implement equals for more classes like the Feed and FeedMedia ?

Checklist

• I have read the contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
• I have performed a self-review of my code
• I have run the automated code checks using ./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug
• My code follows the style guidelines of the AntennaPod project: https://github.com/AntennaPod/AntennaPod/wiki/Code-style
• I have mentioned the corresponding issue and the relevant keyword (e.g., "Closes: #xy") in the description (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
• If it is a core feature, I have added automated tests

[ByteHamster]

Good catch! Looks like I broke this in https://github.com/AntennaPod/AntennaPod/pull/6949/files#diff-9c20b246182eef6913022401d63ea1112a36a7c89c123337fff1c50efe11f6af

Adding to Feed and FeedMedia sounds good, thanks!

[ByteHamster]

Could you please change the target branch to master? Then we can get this directly to the beta releases instead of waiting for the next full release

[flofriday]

I now implemented the methods for all the classes that used to inherit from FeedComponent and rebased on master instead of dev.

[ByteHamster]

Thanks! Will be released in beta3