Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contributors licenses screens #7129

Merged

Conversation

flofriday
Copy link
Contributor

@flofriday flofriday commented Apr 21, 2024

Description

Closes #7123
Closes #7124

This PR includes the following Changes:

  • Adds rounded corners to the avatars of the contributors pages
  • Removes empty space on the License and Translator pages
  • Makes Contributors clickable wich opens their GitHub profile in a browser
  • Makes Licenses clickable which opens the corresponding project
  • All clickable items have a ripple effect to indicate their "clickability ???"

I combined both issues as they work on improving the same parts of the codebase and since both aren't too large on their own.

Checklist

Screenshots

image

On some screenshots I tried to capture the ripple effect, which didn't work too well but you get the gist.

Clicking a contributor leads to their GitHub profile and opening a
license to the project.
The SimpleIconList now only reserves space for an image if it is called
with an imageurl. However, if it is not called with an URL than it
fills the empty space.
@flofriday flofriday force-pushed the improve-contributors-licenses-screens branch from 48e5109 to 107f99c Compare April 21, 2024 21:18
@flofriday flofriday changed the title Improve contributors licenses screens WIP: Improve contributors licenses screens Apr 21, 2024
@flofriday
Copy link
Contributor Author

I think think this is still a work in progress as I just discovered that the licenses already had a well designed menu that pops up when clicked on, which my solution no longer produces.

@flofriday flofriday force-pushed the improve-contributors-licenses-screens branch from 7e13236 to 4d4022b Compare April 22, 2024 14:21
@flofriday flofriday changed the title WIP: Improve contributors licenses screens Improve contributors licenses screens Apr 22, 2024
@flofriday
Copy link
Contributor Author

I reimplemented the clicking on developers and special thanks members, which is now much closer to how the licenses screen does it and fit's in better with the existing code.
Also now the licenses display their popup again which already worked great.

Functionally nothing else changed so it still looks like in the screenshots above, with ripples and all.

@ByteHamster ByteHamster merged commit 7b048ed into AntennaPod:develop Apr 24, 2024
6 checks passed
@ByteHamster
Copy link
Member

Thanks! Will be released in 3.5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill empty space on translation and licences screen Rounded corners for contributor avatars
2 participants