New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show social comment icon on playing screen and item description #7127
base: develop
Are you sure you want to change the base?
Conversation
looks nice. Also, something to consider including in this PR, or maybe in a separate feature: support for rss 2.0 comment element. It is a URL pointing to where the comments can be found (if open in a browser). It seems somewhat widely used and it could be implemented in the same way. If we find both, comments and socialInteract, with different URLs, when the user clicks on the comments icon, we may need a pop up asking which one to open. example: <item>
<title>Fliperama de Boteco #418 – Star Fox 64</title>
<link>https://fliperamadeboteco.com/2024/04/18/fliperama-de-boteco-418-star-fox-64/</link>
<pubDate>Thu, 18 Apr 2024 15:38:12 +0000</pubDate>
<guid isPermaLink="false">https://fliperamadeboteco.com/?p=15458</guid>
<comments>https://fliperamadeboteco.com/2024/04/18/fliperama-de-boteco-418-star-fox-64/#respond</comments>
<!-- .... omitted content -->
</item> |
Btw: I tried to initiate a way for Android apps to agree on a common intent to open an ActivityPub note, so that we don't have to open the browser but can redirect to the user's favourite app. But that didn't really work out and I don't have enough understanding of the system to drive it anywhere. Maybe any of you have any useful to say (especially in context of this PR): |
I think we should go into the other direction with the icons in the topbar. Five icons is definitely too much clutter, especially if the spec limits it at three. What about a button after the description that leads to the comments? Or if you all feel really strong about keeping this feature in the top bar we should think about which other icon we should spill into the overflow. |
I think we should approach this strategically, and have some proper thinking on the UX/UI generally. Maybe we should use one of the community meetings or Needs: Decision meetings to explore the options. |
Fix #7078
Description
Display the social interest url from podcasting 2.0 spec on the playing and item description screen as icons.
Still todo
priority
field and display the highest priority link when there are more than onesocialInteract
link, https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/1.0.md#social-interactaccountId
anduri
onhover before users click throughChecklist
./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug