Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature fastfilter #6847

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

ueen
Copy link
Contributor

@ueen ueen commented Jan 2, 2024

FAB for filtermenu added to episodes list, long press for reset filters.

I'm just putting it out there, i used it for a week and like it a lot, could be made optional, but i'd advocate for enabled by default ;)

@ueen ueen changed the title Improv fastfilter New feature fastfilter Jan 2, 2024
@keunes
Copy link
Member

keunes commented Jan 2, 2024

Not sure I'm a fan of this. Can you please create a feature request that describes the use-case and provides screenshots? Maybe that can convince me :-)

@ueen
Copy link
Contributor Author

ueen commented Jan 2, 2024

Already did all of that in the forum :)
https://forum.antennapod.org/t/further-home-screen-improvements/2479/13

its not something you or anybody else has to use, but I believe that it is useful and a lot of people will want to use it (or at least have the option)

@keunes
Copy link
Member

keunes commented Jan 2, 2024

Ah, ok, thanks. I didn't get to that thread yet - it was in my open tab list :P

For future reference, it's helpful if you add such links in the PR description.

@ueen
Copy link
Contributor Author

ueen commented Jan 2, 2024

Please also take this #6848 into your consideration, when the episodes list is expanded on home we either have to add filter to the toolbar, which i do not prefer, or do this PR and have a nice fast, thumbfriendly filtering solution :)

I believe this filter FAB is also great for episodes list and maybe even feedlists but we could also restrict it so expanded home episodes section.

@ByteHamster ByteHamster added the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Decision Proposal and most arguments are clear, but needs a verdict.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants