Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner on home screen if notification permission is not granted #6412

Merged

Conversation

ByteHamster
Copy link
Member

No description provided.

@keunes
Copy link
Member

keunes commented Apr 4, 2023

Can it be dismissed easily?

@ByteHamster
Copy link
Member Author

ByteHamster commented Apr 4, 2023

No, only by granting the permission. Note that you can still disable notifications, this is just about the "global" permission to show notifications at all (on Android 13). Without the permission, we can't notify users if a download fails etc. So I think it is important enough to really nag users. (The app can still be used without granting if someone really doesn't want to grant, but then they need to always look at that banner)

In the far future, we might want to think about if we can make the app usable without any notifications. But that's a whole different story.

@ByteHamster ByteHamster merged commit 39d309e into AntennaPod:develop Apr 7, 2023
7 checks passed
@ByteHamster ByteHamster deleted the notification-permission branch April 7, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants