close the outputstrean even thouht there were throwing an exception #6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteHamster
reviewed
Mar 23, 2023
| IOUtils.copy(data, outputStream); | ||
| outputStream.close(); | ||
| //outputStream.close(); |
There was a problem hiding this comment.
I think if we don't close it here, we risk an incomplete file when reading it a few statements later
There was a problem hiding this comment.
yes，it‘s right.
but it will be closed in finally block.
if we colose here, there maybe throws an exception on before statement "IOUtils.copy(data, outputStream);".
closing it on the finally block,it will be execute in anyway.
There was a problem hiding this comment.
The finally block is too late. It needs to be closed earlier. By the time that the finally block is executed, we have already tried to read the created (incomplete) file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.