New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "always" mode for shake to reset sleep #6165
base: develop
Are you sure you want to change the base?
Added "always" mode for shake to reset sleep #6165
Conversation
I'm not entirely sure if we want that feature. Pre-actively shaking your phone every few minutes without actually running into the sleep timer countdown feels a lot more cumbersome than just shaking when the countdown actually starts reducing the volume. We already discussed this in #4825. Feel free to join the discussion there and tell us about your use-case. Why is it better to regularly shake the phone during playback, trying to guess how much time passed, than to simply shake it when the timer is about to expire? |
Thanks for the update. I've stepped into the discussion there. |
Hey @ByteHamster , |
# Conflicts: # app/src/main/java/de/danoeh/antennapod/dialog/SleepTimerDialog.java # core/src/main/java/de/danoeh/antennapod/core/preferences/SleepTimerPreferences.java
# Conflicts: # app/src/main/res/layout/time_dialog.xml
Shaking to reset the sleep timer only at the end of the timer is not always helpful. A mayor use case is to allow shaking all the time. Several podcast and audio book players having the feature available like this, which makes it a lot more handy.
To fulfill this I've added a spinner to allow selection of the reset mode:
This allows the user to select if shaking should be always detected or only at the end.
Closes #4825