Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "always" mode for shake to reset sleep #6165

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Fruchtzwerg94
Copy link

@Fruchtzwerg94 Fruchtzwerg94 commented Oct 27, 2022

Shaking to reset the sleep timer only at the end of the timer is not always helpful. A mayor use case is to allow shaking all the time. Several podcast and audio book players having the feature available like this, which makes it a lot more handy.
To fulfill this I've added a spinner to allow selection of the reset mode:
Screenshot_20221027-223437_AntennaPod Debug
Screenshot_20221027-223455_AntennaPod Debug
This allows the user to select if shaking should be always detected or only at the end.

Closes #4825

@ByteHamster
Copy link
Member

I'm not entirely sure if we want that feature. Pre-actively shaking your phone every few minutes without actually running into the sleep timer countdown feels a lot more cumbersome than just shaking when the countdown actually starts reducing the volume. We already discussed this in #4825. Feel free to join the discussion there and tell us about your use-case. Why is it better to regularly shake the phone during playback, trying to guess how much time passed, than to simply shake it when the timer is about to expire?

@Fruchtzwerg94
Copy link
Author

I'm not entirely sure if we want that feature. Pre-actively shaking your phone every few minutes without actually running into the sleep timer countdown feels a lot more cumbersome than just shaking when the countdown actually starts reducing the volume. We already discussed this in #4825. Feel free to join the discussion there and tell us about your use-case. Why is it better to regularly shake the phone during playback, trying to guess how much time passed, than to simply shake it when the timer is about to expire?

Thanks for the update. I've stepped into the discussion there.

@Fruchtzwerg94
Copy link
Author

Fruchtzwerg94 commented Feb 4, 2023

Hey @ByteHamster ,
is there any update on this feature? Till now, I can't find any reason not to introduce the option. The default behaviour of the app is not changed and its a still nice improvement in terms of usability.
It would be awesome to have this feature as part of the next official relasese.
Cheers

# Conflicts:
#	app/src/main/java/de/danoeh/antennapod/dialog/SleepTimerDialog.java
#	core/src/main/java/de/danoeh/antennapod/core/preferences/SleepTimerPreferences.java
@ByteHamster ByteHamster added the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Decision Proposal and most arguments are clear, but needs a verdict.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to allow "Shake to reset" in SleepTimer at any time during the countdown
2 participants