Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option "do not add playing episodes to the queue" #4339

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

asdoi
Copy link
Contributor

@asdoi asdoi commented Aug 2, 2020

Some users, including me, just want to listen to a podcast and do not want that it gets automatically added to the queue.
Futhermore I only want to see episodes showing up in the queue if I manually add them.

This adds the matching "auto enqueue playing" media setting.
Closes #3246

@ByteHamster
Copy link
Member

This change sounds like it could be a bit risky. What episodes does AntennaPod play next when enabling the "Follow queue" setting? How do external media players display the queue (we send it to them using a MediaSession). What happens when you skip an episode? One should probably have a close look at PlaybackService.getNextInQueue() method to make sure that this does not break something.

@asdoi
Copy link
Contributor Author

asdoi commented Aug 3, 2020

The behaviour should be same like playing an episode and then manually removing it from the queue.
Furthermore I played episodes with follow queue enabled and if the episode is over the playback stops, like it does normally if the item is not in the queue. And in my tests I do not get any error or anything else.

@Pentaphon
Copy link

I totally agree with this. I don't want to use the queue at all unless I want to make a queue for some special reason like I need 3 podcasts to play in order because I don't want to use my hands to switch to the next podcast when I'm busy for a couple of hours. Also, I usually want to listen to 1 podcast at a time and I don't want it to continue to another podcast I have downloaded for later.

@ByteHamster
Copy link
Member

Now that I think of it, it could actually also be valid to never add playing episodes to the queue automatically and follow whatever list you look at when pressing the play button. I am still a bit undecided in what direction the queue feature should go in the future.

@Pentaphon
Copy link

and follow whatever list you look at when pressing the play button.

Yep, think of it as manual versus automatic mode. It also avoids accidentally falling asleep to a single podcast only to find out you played your whole queue you didn't realize you made overnight and have to download the episodes again. That's happened to me once.

@ByteHamster ByteHamster added the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Jul 16, 2023
@keunes
Copy link
Member

keunes commented Jan 2, 2024

I usually want to listen to 1 podcast at a time and I don't want it to continue to another podcast I have downloaded for later

and

could actually also be valid to never add playing episodes to the queue automatically and follow whatever list you look at when pressing the play button

That's indeed requested through #1533.

think of it as manual versus automatic mode. It also avoids accidentally falling asleep to a single podcast only to find out you played [overnight] your whole queue you didn't realize you made

There are already measures you can take: disable continuous playback and/or automatic download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Decision Proposal and most arguments are clear, but needs a verdict.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to not automatically add played items to queue
4 participants