Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show social comment icon on playing screen and item description #7127

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tonytamsf
Copy link
Member

@tonytamsf tonytamsf commented Apr 21, 2024

Fix #7078

Description

Display the social interest url from podcasting 2.0 spec on the playing and item description screen as icons.

Still todo

Checklist

screenshot-1
screenshot-2

@tonytamsf tonytamsf added the Area: Podcast Index / Podcasting 2.0 Anything related to PodcastIndex.org and/or Podcasting 2.0 label Apr 21, 2024
@dellagustin
Copy link

looks nice.
<podcast:socialInteract> could appear multiple times for different protocols (in theory), but right now only protocol="mastodon" is used. protocol="twitter" was explored as well if I'm not mistaken, but I'm not sure it is in use.
Maybe it would be good to currently filter for protocol="mastodon".

Also, something to consider including in this PR, or maybe in a separate feature: support for rss 2.0 comment element. It is a URL pointing to where the comments can be found (if open in a browser). It seems somewhat widely used and it could be implemented in the same way. If we find both, comments and socialInteract, with different URLs, when the user clicks on the comments icon, we may need a pop up asking which one to open.

example:

	<item>
		<title>Fliperama de Boteco #418 &#8211; Star Fox 64</title>
		<link>https://fliperamadeboteco.com/2024/04/18/fliperama-de-boteco-418-star-fox-64/</link>
		<pubDate>Thu, 18 Apr 2024 15:38:12 +0000</pubDate>
		<guid isPermaLink="false">https://fliperamadeboteco.com/?p=15458</guid>
		<comments>https://fliperamadeboteco.com/2024/04/18/fliperama-de-boteco-418-star-fox-64/#respond</comments>
                <!-- .... omitted content -->
	</item>

@keunes
Copy link
Member

keunes commented Apr 21, 2024

Btw: I tried to initiate a way for Android apps to agree on a common intent to open an ActivityPub note, so that we don't have to open the browser but can redirect to the user's favourite app. But that didn't really work out and I don't have enough understanding of the system to drive it anywhere. Maybe any of you have any useful to say (especially in context of this PR):
https://socialhub.activitypub.rocks/t/possible-fep-proposal-cross-android-app-way-to-open-object/2985

@keunes
Copy link
Member

keunes commented Apr 21, 2024

If we find both, comments and socialInteract, with different URLs, when the user clicks on the comments icon, we may need a pop up asking which one to open.

Maybe not a full pop-up but a more subtle pop-out, aun upgraded overflow menu, something like this:
jzgO6-2015555944.png

It'd be nice if that way we could allow the user to still press other buttons (e.g. pause in the player screen).

@flofriday
Copy link
Contributor

I think we should go into the other direction with the icons in the topbar. Five icons is definitely too much clutter, especially if the spec limits it at three.

What about a button after the description that leads to the comments?

Or if you all feel really strong about keeping this feature in the top bar we should think about which other icon we should spill into the overflow.

@keunes
Copy link
Member

keunes commented Apr 22, 2024

I think we should approach this strategically, and have some proper thinking on the UX/UI generally. Maybe we should use one of the community meetings or Needs: Decision meetings to explore the options.

@tonytamsf tonytamsf added the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Podcast Index / Podcasting 2.0 Anything related to PodcastIndex.org and/or Podcasting 2.0 Needs: Decision Proposal and most arguments are clear, but needs a verdict.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for comments based on ActivityPub (podcast:socialInteract)
4 participants