Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 2nd section fill screen space on Home if only 2 sections are present #6229

Open
3 tasks done
keunes opened this issue Dec 10, 2022 · 2 comments · May be fixed by #6848
Open
3 tasks done

Make 2nd section fill screen space on Home if only 2 sections are present #6229

keunes opened this issue Dec 10, 2022 · 2 comments · May be fixed by #6848

Comments

@keunes
Copy link
Member

keunes commented Dec 10, 2022

Checklist

  • I have used the search function for open and closed issues to see if someone else has already submitted the same feature request.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.0 alpha

Where did you get the app from

Google Play

Problem you may be having, or feature you want

@ueen is interested in having a 'home' screen with just two sections: the Continue listening and Review the new. Currently, when disabling all but 2 sections, the use of screen space isn't optimised and, depending on the device form factor, a large part of the screen may be blank.

Suggested solution

When only 2 sections are active, and the second section is a (regular) vertical list, change the second (bottom) section as follows:

  • expand the section to the bottom of the screen, so it takes up all available space
  • present the full list of items, not limited to 2 rows for 'normal' sections, and make the list scrollable

Effectively, the first section will always be visible, as scrolling happens at the level of the section, not at the level of the screen. If the user pulls (scrolls) down from a non-scrolling area, or if the user pulls (scrolls) down in a scrolling area but is at the top of the view/list, this should trigger a (feed) refresh.

Screenshots / Drawings / Technical details

Blocked by (or should be implemented together with) #6068, because otherwise the section expansion will only be possible with a (very) limited set of combinations of sections.

Otherwise, the home screen should stay as is; sections with the (vertical) list with 2 rows, should remain not-scrollable.

If the second section is not a vertical but a horizontal list, the section is showing as usual (not a vertically expanded list).

@antennapod-bot
Copy link

antennapod-bot commented Dec 10, 2022

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/monthly-community-call/1869/33

And on X: https://twitter.com/krishnanrohit/status/1738057645641327004

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/home-feature-expanable-episodes-list-and-inbox/3891/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants