Skip to content
This repository has been archived by the owner on Oct 16, 2021. It is now read-only.

Service worker tweaks #134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

zplume
Copy link

@zplume zplume commented Jun 19, 2020

Details / conversation here:
#133

Thanks!

@zplume
Copy link
Author

zplume commented Jun 19, 2020

src\_includes\partials\global\service-worker.js currently excludes any URLs containing .netlify so the Netlify preview build doesn't quite work as expected: pre-caching and the 'offline' page works, but runtime caching doesn't as everything relative to the *.netlify.app domain is excluded.

Not sure if this is intentional (preventing runtime caching on *.netlify.app domains), but commenting out / removing this line should resolve it:

image

@Andy-set-studio
Copy link
Owner

Thanks for this! I don't have time for a review right now (got a course to release 😉), but I'll add this to my list for next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants