Skip to content
This repository has been archived by the owner on Oct 16, 2021. It is now read-only.

Service worker tweaks #133

Open
zplume opened this issue Jun 19, 2020 · 1 comment
Open

Service worker tweaks #133

zplume opened this issue Jun 19, 2020 · 1 comment

Comments

@zplume
Copy link

zplume commented Jun 19, 2020

Hi @hankchizljaw,

I've been testing out the service worker implementation in Hylia and noticed some opportunity for minor improvements, if you're interested:

  • Serve an 'offline' page (from the pre-cache) if the user attempts to navigate while offline.
  • Rebuild 11ty when src/_includes/partials/global/service-worker.js is updated.
  • Exclude browser sync requests from the runtime cache (removes 'noise' from if you are testing on http://localhost / ngrok).

I've created a service-worker branch in my fork of Hylia with commits that address each of the above bullet points:
https://github.com/zplume/hylia/commits/service-worker

Would you be interested in a PR containing the above?

Thanks!

@Andy-set-studio
Copy link
Owner

Yes please, that would be great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants