-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace aero.py with rusty build system #81
base: master
Are you sure you want to change the base?
Conversation
i just want to point out that aero used to have a build system written in rust and it was replaced by the python script due to how long the initial build took, primarily because of the fact we download stuff from the internet and it used |
that's the goal! aiming to use the smallest, fastest crates i can find |
won't be working on this until the 1st, ran out of hours on Gitpod 😢 |
by the way, currently, just using |
gumdrop seems fine, you can get rid of termcolor as it seems to bring in a lot of winapi bullshit which is basically useless because aero doesn't have first class support for windows and it's a hefty crate (>1 MB), just implement ansi colors yourself with ansi escapes, it's very easy :') |
additionally the newer windows terminal support ansi escapes just fine so it shouldn't be a problem, i'm not sure if termcolor gates the winapi dependency behind a feature, but if it does then it might be wise to disable it |
cool, i'll look into that |
looks like it only uses it when the compile target is windows but it's still pretty hefty. |
8dce81a
to
2a08281
Compare
accidentally started the workspace from master instead of rust-build and had to force push like a fool 🥲 |
ebad1c8
to
f1ba94d
Compare
Just a comment, I think it's reasonable to say leaving out Windows/cygwin/etc compatibility for now should probably be fine, since anything WinApi is a massive pain and tends to add a lot of cruft/bloat. I'm going to take a look at what you have, and maybe throw some tests your way :) |
I totally agree with that comment, the days of MSYS/Cygwin are numbered ever since WSL became a thing (and Windows 7 is EOL.) I don't think crippling our build system just to support exotic setups is a reasonable choice. Let's just keep it simple :^) |
i need to pull some upstream changes but i cba yet |
90094ea
to
5222520
Compare
1de1b56
to
f7cd1a0
Compare
51c9079
to
9105725
Compare
this implementation will hopefully be faster and more maintainable
important things:
aero_build
from aero.pynote to self: don't forget to add a comment referencing this gist to the logging functions.