v13 structure rewrite #689
Conversation
…slint configuration and remove discord-paginationembed
| files.filter((file) => file.split(".").pop() === "js").forEach(file => { | ||
| try { | ||
| const event = new (require(`../events/${directory}/${file}`))(this); | ||
| this.logger.log(`Loading Event: ${file.split(".")[0]}`); |
There was a problem hiding this comment.
| this.logger.log(`Loading Event: ${file.split(".")[0]}`); | |
| this.logger.log(`Loading Event: ${file.split(".")[0]}`, "log"); |
There was a problem hiding this comment.
"log" is set by default if the second arg of log() is not specified
| @@ -46,11 +51,11 @@ module.exports = class { | |||
| }); | |||
| if(status[parseInt(i+1, 10)]) i++; | |||
| else i = 0; | |||
| }, 20000); // Every 20 seconds | |||
| }, 2e4); // Every 20 seconds | |||
There was a problem hiding this comment.
I think it's a good idea in a program that requires a lot of performance management like in C/C++, and therefore requires relatively precise values. In our case I think it's not really necessary and it takes away clarity.
|
|
||
| setTimeout(() => { | ||
| console.log(chalk.magenta("\n\nLike this bot?"), "Support us by adding a star on GitHub ❤️ https://github.com/Androz2091/AtlantaBot"); | ||
| }, 400); | ||
| }, 1e4); |
|
Thanks a lot for your pull request. I will use your structure to make the bases of the next version of Atlanta. |
But this pr has been verified by Androz and probably be merge when the commands will be added. |
|
I understand, and the point is that at the moment the way the commands are done is not appropriate to work with the commands apps, a version 5 is already in the works, and I based myself on the structure that you proposed. I discussed it with Androz, we concluded that the next version (5) which should be released shortly will use a provisional operation, in order to provide a first version of Atlanta working with discord.js. It was accepted that we are not going to seek to optimize or remodel the bot in its version 5, we have decided to wait until discord.js releases its stable version 14, and we will completely rewrite the bot with this version, as well as the dashboard, and everything, in TypeScript, for the v6 of the bot. Therefore, in its version 5 in wip, we will only seek to test the operation of the bot with app commands. |
|
This pr actually support application commands |
|
Yes indeed, they allow support for application commands, but they don't use them in any command except ping, so on my side I rewrote all the bot commands to work with slash commands. |
First work of djs v13 support (base of the structure)