[GoDaddy] Prevent invalid tts values and fix use subdomain #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
GiviMAD
force-pushed
the
godaddy/tll_and_subdomains
branch
from
6704722
to
2c49487
Compare
|
I messed up with the second commit, I think now it's correct, let me know if there is something wrong there. I think the CI error is not due to my changes but I'm not sure if I'm right. BR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm using these project as part of Nginx Proxy Manager and I encountered some errors trying to run the DNS challenge for GoDaddy for a subdomain. I'm able to do it with the proposed changes.
Hope everything is ok I'm not too in touch with python.
Amazing project by the way :)