Fixing ReferenceError in catch block #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending error to channel results in a ReferenceError because cleaned is not defined in the catch block's scope. Replaced with sending the error's stack to resolve this.
| @@ -109,7 +109,7 @@ client.on("messageCreate", async (message) => { | |||
| message.channel.send(`\`\`\`js\n${cleaned}\n\`\`\``); | |||
| } catch (err) { | |||
| // Reply in the channel with our error | |||
| message.channel.send(`\`ERROR\` \`\`\`xl\n${cleaned}\n\`\`\``); | |||
| message.channel.send(`\`ERROR\` \`\`\`xl\n${err.stack}\n\`\`\``); | |||
There was a problem hiding this comment.
- This doesn't send the actual error.
- err.stack is
string[]?meaning it could be undefined.
There was a problem hiding this comment.
- This doesn't send the actual error.
- err.stack is
string[]?meaning it could be undefined.
Error#stackdoes send the actual error message, plus the error stack.- Technically
erris of typeunknown, so an instance check forErrorwould be appropriate here, but the chances of a non-error type being thrown is unlikely.
There was a problem hiding this comment.
@RealShadowNova... oops; implementation issue with the way my stack system works. soz!
|
can you screenshot what actually happens? |
As You could always just send the plain Error, but that will not provide any information regarding the actual location of the error, just the type and message associated with it. |
thetayloredman
approved these changes
Jul 31, 2022
migue802
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending error to channel results in a ReferenceError because cleaned is not defined in the catch block's scope.
Replaced with sending the error's stack to resolve this.