Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storageurl in dev #1849

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JKamsker
Copy link

@JKamsker JKamsker commented Apr 2, 2024

Probably fixes #1683

Problem for me was, that the "download pdf" button redirected me to the right url, but the wrong port after changing the storage port in the .env file

@AmruthPillai
Copy link
Owner

The issue is, if you're not running in Development mode, this code block never gets accessed, and NODE_ENV is set to development only when running the app using pnpm dev.

The port is not always included in the storage URL. For example, if the storage service is running on a seperate domain/IP, on either port 80 or 443, then you wouldn't need a port. This is why I initially recommended to add the port in the STORAGE_URL env. This works no matter what environment you are running in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Link for documentation for local deployment?
2 participants