Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(artboard): truncate link to stop overflow #1846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abizek
Copy link
Contributor

@abizek abizek commented Apr 2, 2024

Fixes #1814

The issue only mentions link overflow in the certificates section but this can happen to any link in the resume. Due to the current component structure, we can fix it only by truncating all links in a resume template.

Warning

This will break resumes depending on link URL/label word wrap for layout.

This is just a simple fix. There are so many questions I have in my mind. Should we line-clamp instead? If so, how many lines? Should we use container query units instead of the arbitrary 256px max-width? But all of these can break some existing resumes, so do we just let the links overflow and suggest using labels and link shorteners instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Off-screen text] <Off-screen text when adding certificate link>
1 participant