Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate links option to reduce section item height #1823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jzaehrin
Copy link

@jzaehrin jzaehrin commented Mar 21, 2024

I just discovered this amazing project and I would like to help. I am rusty from the little experience I've had with React. I welcome any advice and opinions.

This is a Draft of an option to regroup links of section's items:

screenshot-2024-03-21_17-19-09
screenshot-2024-03-21_17-20-39
screenshot-2024-03-21_17-21-12
screenshot-2024-03-21_17-21-26

This is a first idea, but it would also be possible to have the option at the section level. I suppose it would be a good idea to wrap this ternary condition to avoid reading heaviness.

I'm waiting for opinions/suggestions/approvals to complete this work.

To do:

  • Adapt all templates with the features

@jzaehrin jzaehrin marked this pull request as draft March 21, 2024 20:36
@jzaehrin jzaehrin changed the title Draft: feat: separate links option to reduce section item height feat: separate links option to reduce section item height Mar 21, 2024
@jzaehrin jzaehrin marked this pull request as ready for review March 21, 2024 20:37
@jzaehrin jzaehrin marked this pull request as draft March 21, 2024 20:37
@jzaehrin
Copy link
Author

jzaehrin commented Mar 24, 2024

Rework: Better code style

@jzaehrin
Copy link
Author

I moved the option at the section level, the toggle is now present in the dropdown menu per section to have granular options

screenshot-2024-03-25_17-26-54
screenshot-2024-03-25_17-27-05

I finished the full implementation

@jzaehrin jzaehrin marked this pull request as ready for review March 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant