revert structuredClone as it is not supported on proxy objects

AmruthPillai · May 10, 2024 · c15d9f7 · c15d9f7
1 parent a102f62
commit c15d9f7
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 14 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -76,7 +76,8 @@
         // unicorn
         "unicorn/no-null": "off",
         "unicorn/prevent-abbreviations": "off",
-        "unicorn/prefer-string-replace-all": "off"
+        "unicorn/prefer-string-replace-all": "off",
+        "unicorn/prefer-structured-clone": "off"
       }
     },
     {

diff --git a/apps/client/src/pages/builder/sidebars/left/sections/custom/section.tsx b/apps/client/src/pages/builder/sidebars/left/sections/custom/section.tsx
@@ -91,7 +91,7 @@ export const CustomFieldsSection = ({ className }: Props) => {
 
   const onChangeCustomField = (field: ICustomField) => {
     const index = customFields.findIndex((item) => item.id === field.id);
-    const newCustomFields = structuredClone(customFields);
+    const newCustomFields = JSON.parse(JSON.stringify(customFields));
     newCustomFields[index] = field;
 
     setValue("basics.customFields", newCustomFields);

diff --git a/apps/client/src/pages/builder/sidebars/right/sections/layout.tsx b/apps/client/src/pages/builder/sidebars/right/sections/layout.tsx
@@ -163,15 +163,15 @@ export const LayoutSection = () => {
   };
 
   const onAddPage = () => {
-    const layoutCopy = structuredClone(layout);
+    const layoutCopy = JSON.parse(JSON.stringify(layout));
 
     layoutCopy.push([[], []]);
 
     setValue("metadata.layout", layoutCopy);
   };
 
   const onRemovePage = (page: number) => {
-    const layoutCopy = structuredClone(layout);
+    const layoutCopy = JSON.parse(JSON.stringify(layout));
 
     layoutCopy[0][0].push(...layoutCopy[page][0]); // Main
     layoutCopy[0][1].push(...layoutCopy[page][1]); // Sidebar
@@ -182,7 +182,7 @@ export const LayoutSection = () => {
   };
 
   const onResetLayout = () => {
-    const layoutCopy = structuredClone(defaultMetadata.layout);
+    const layoutCopy = JSON.parse(JSON.stringify(defaultMetadata.layout));
 
     // Loop through all pages and columns, and get any sections that start with "custom."
     // These should be appended to the first page of the new layout.

diff --git a/apps/client/src/stores/resume.ts b/apps/client/src/stores/resume.ts
@@ -35,7 +35,7 @@ export const useResumeStore = create<ResumeStore>()(
             state.resume.data = _set(state.resume.data, path, value);
           }
 
-          void debouncedUpdateResume(structuredClone(state.resume));
+          void debouncedUpdateResume(JSON.parse(JSON.stringify(state.resume)));
         });
       },
       addSection: () => {
@@ -51,7 +51,7 @@ export const useResumeStore = create<ResumeStore>()(
           state.resume.data.metadata.layout[lastPageIndex][0].push(`custom.${section.id}`);
           state.resume.data = _set(state.resume.data, `sections.custom.${section.id}`, section);
 
-          void debouncedUpdateResume(structuredClone(state.resume));
+          void debouncedUpdateResume(JSON.parse(JSON.stringify(state.resume)));
         });
       },
       removeSection: (sectionId: SectionKey) => {
@@ -63,7 +63,7 @@ export const useResumeStore = create<ResumeStore>()(
             // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
             delete state.resume.data.sections.custom[id];
 
-            void debouncedUpdateResume(structuredClone(state.resume));
+            void debouncedUpdateResume(JSON.parse(JSON.stringify(state.resume)));
           });
         }
       },

diff --git a/libs/parser/src/json-resume/index.ts b/libs/parser/src/json-resume/index.ts
@@ -57,7 +57,7 @@ export class JsonResumeParser implements Parser<Json, JsonResume> {
   }
 
   convert(data: JsonResume) {
-    const result = structuredClone(defaultResumeData);
+    const result = JSON.parse(JSON.stringify(defaultResumeData));
 
     // Basics
     result.basics.name = data.basics?.name ?? "";

diff --git a/libs/parser/src/linkedin/index.ts b/libs/parser/src/linkedin/index.ts
@@ -57,7 +57,7 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
   }
 
   convert(data: LinkedIn) {
-    const result = structuredClone(defaultResumeData);
+    const result = JSON.parse(JSON.stringify(defaultResumeData));
 
     // Profile
     if (data.Profile && data.Profile.length > 0) {

diff --git a/libs/parser/src/reactive-resume-v3/index.ts b/libs/parser/src/reactive-resume-v3/index.ts
@@ -59,7 +59,7 @@ export class ReactiveResumeV3Parser implements Parser<Json, ReactiveResumeV3> {
   }
 
   convert(data: ReactiveResumeV3) {
-    const result = structuredClone(defaultResumeData);
+    const result = JSON.parse(JSON.stringify(defaultResumeData));
 
     // Basics
     result.basics.name = data.basics.name ?? "";

diff --git a/libs/utils/src/namespaces/array.ts b/libs/utils/src/namespaces/array.ts
@@ -34,7 +34,7 @@ export const moveItemInLayout = (
 ): string[][][] => {
   try {
     // Create a deep copy of the layout to avoid mutating the original array
-    const newLayout = structuredClone(layout);
+    const newLayout = JSON.parse(JSON.stringify(layout));
 
     // Get the item from the current location
     const item = newLayout[current.page][current.column][current.section];

diff --git a/libs/utils/src/namespaces/tests/array.test.ts b/libs/utils/src/namespaces/tests/array.test.ts
@@ -84,7 +84,7 @@ describe("moveItemInLayout", () => {
       [["item1"], ["item2"]],
       [["item3"], ["item4"]],
     ];
-    const layoutCopy = structuredClone(layout);
+    const layoutCopy = JSON.parse(JSON.stringify(layout));
     const current = { page: 0, column: 1, section: 0 };
     const target = { page: 1, column: 0, section: 1 };
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@reactive-resume/source",
   "description": "A free and open-source resume builder that simplifies the process of creating, updating, and sharing your resume.",
-  "version": "4.1.2",
+  "version": "4.1.3",
   "license": "MIT",
   "private": true,
   "author": {