convert herocard to tsx #852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttornese
reviewed
Jul 27, 2022
| @@ -86,7 +86,7 @@ const HeroCardTitle = styled.div` | |||
| margin-bottom: ${spacing.xxsm}; | |||
| `; | |||
|
|
|||
| const HeroCardDescription = styled.div` | |||
| const HeroCardDescription = styled.div<{ cardType: string }>` | |||
There was a problem hiding this comment.
seems like cardType is one of 'learn' | 'watch' rather than a generic string, might want to change the typing here to reflect that
jwinnfeild2517
force-pushed
the
herocard-tsx
branch
from
4092992
to
8a2b9db
Compare
oddwili
requested changes
Aug 2, 2022
Comment on lines
157
to
173
| /** Image rendered as background for card. */ | ||
| backgroundCloudinaryId: string, | ||
| ctaUrl?: string, | ||
| /** text for card CTA */ | ||
| ctaText: string, | ||
| /** Description text above CTA */ | ||
| description: string, | ||
| /** Optional: Key value that maps to a show logo. */ | ||
| iconKey?: string, | ||
| /** Optional: Image data that is used to render a PersonHeadShot. */ | ||
| personHeadShot: PersonHeadshotPropTypes, | ||
| /** Optional: Data used to render a sticker. */ | ||
| sticker: PropTypes.InferProps<typeof Sticker.propTypes>, | ||
| /** Title text above description */ | ||
| title?: string, | ||
| onClick?: () => void, | ||
|
|
There was a problem hiding this comment.
We should remove the comments here. It's clear from the names what the props do and the props that are optional are denoted with a ?
jwinnfeild2517
force-pushed
the
herocard-tsx
branch
from
8a2b9db
to
6833ec6
Compare
jwinnfeild2517
force-pushed
the
herocard-tsx
branch
from
6833ec6
to
63ca286
Compare
added 2 commits
August 18, 2022 11:38
jwinnfeild2517
force-pushed
the
herocard-tsx
branch
from
af1ff91
to
6662907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the Pr do
converts the herocard into typescript