Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #43 and #48: Option to limit requested certificates #50

Merged
merged 5 commits into from
Jul 23, 2019
Merged

Fixes #43 and #48: Option to limit requested certificates #50

merged 5 commits into from
Jul 23, 2019

Conversation

kienanstewart
Copy link
Contributor

For #43:

Add '-c' option to generate_certbot to choose which types of certificates to request

The script will request all certificates by default, or the value of the
environment variable ALTERNC_REQUEST_CERTIFICATES if is set.

Changes were made to the install.d script and the cronjob to support this. The
cron job will request all certificates explicitly. The install.d script will
default to all if the variable isn't set in local.sh, but will override the
environment variable set if the flag '--all' is present in the arguments.

For #48:

Applied changes to resolve issues raised by @quenenni : calling an undefined function (m_ssl::fqdnMatch), a mistake in the condition that checks if a sub_domain has a certificate_id set, and cleaned up the logic around determining if a certificate is still valid.

I did all the changes in one PR since the PR for #43 introduces a relatively large diff (given the size of the file). I can split this out in the two PRs if y'all want though.

Kienan Stewart added 4 commits May 24, 2019 13:19
Add '-c' option to generate_certbot to choose which types of certific…
7015167 
…ates to request

The script will request all certificates by default, or the value of the
environment variable ALTERNC_REQUEST_CERTIFICATES if is set.

Changes were made to the install.d script and the cronjob to support this. The
cron job will request all certificates explicitly. The install.d script will
default to all if the variable isn't set in local.sh, but will override the
environment variable set if the flag '--all' is present in the arguments.
Fix check for certificate_id
acb92cd 
Refs AlternC#48
Fix call to undefined function
8f806d4 
Refs AlternC#48
Fix condition for checking if a cert is still valid for 30 days
88be1ca 
Refs AlternC#48
This was referenced May 24, 2019
Open
Closed
@camlafit
Copy link
Collaborator

Hello

Thank a lot, first review looks great.

As this PR is relative big could be useful to split it. To help review to each specific ask.

As #48 looks minor, we can merge second PR after this PR.
To not open a new PR or maintain dead code here, if you want you can force this branch to remove #48 part.

@camlafit camlafit merged commit fc93ca9 into AlternC:master Jul 23, 2019
camlafit added a commit that referenced this pull request Nov 18, 2021
@camlafit
Release : 0.0.16
b436230 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
camlafit added a commit that referenced this pull request Nov 22, 2021
@camlafit
Release : 0.0.16
1d9ca4d 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
camlafit added a commit that referenced this pull request Nov 22, 2021
@camlafit
Release : 0.0.16
c5b0702 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
camlafit added a commit that referenced this pull request Dec 2, 2021
@camlafit
Release : 0.0.16
1c62f7b 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kienanstewart @camlafit