Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search certificates for sub domains during dns reload #30

Merged
merged 4 commits into from
Oct 28, 2018
Merged

search certificates for sub domains during dns reload #30

merged 4 commits into from
Oct 28, 2018

Conversation

kienanstewart
Copy link
Contributor

See #29

@kienanstewart
Make getting the account id for a domain more reliable
106da76 
The query proposed by the previous function,
get_sub_domain_id_and_member_by_name() failed in some cases.
@kienanstewart
Import certificates for all sub domains during dns_reload_zone
ea2c921
@kienanstewart
Fix error output of certbot runs
c6eddd8 
Certbot writes useful information to stderr during a failure, but not
stdout. Redirecting stderr to stdout allows exec to capture it and be
included in the log for analysis.
camlafit
camlafit reviewed Oct 28, 2018
View reviewed changes
Copy link
Collaborator

@camlafit camlafit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change on m_certbot (about exec() and 2>&1) is not related to this PR , could you provide an another PR to this specific patch ?
Thanks :)

@camlafit camlafit merged commit 52f74c2 into AlternC:master Oct 28, 2018
camlafit added a commit that referenced this pull request Nov 18, 2021
@camlafit
Release : 0.0.16
b436230 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
camlafit added a commit that referenced this pull request Nov 22, 2021
@camlafit
Release : 0.0.16
1d9ca4d 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
camlafit added a commit that referenced this pull request Nov 22, 2021
@camlafit
Release : 0.0.16
c5b0702 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
camlafit added a commit that referenced this pull request Dec 2, 2021
@camlafit
Release : 0.0.16
1c62f7b 
* Correct packaging system
 * 0.0.15 was always done with fpm and not debuild
* Use travis to build pacakge
 * Package is build on each tag push
 * Nightly package is done on each master commit
* Provide package on github
 * bintray service is removed
* Renew only outdated or missing certificates
* Add option to manage specific certificates group
* Better support certbot (acme protocol)

Solves :
  * #72 #71 : Provide nightly build
  * #69 #65 : Finalize 0.0.15 and remove fpm for debuild
  * #67 #66 : Bintray service is removed
  * #54 #53 : Fix typo
  * #50 #48 : Fix php error
  * #50 #43 : Add an option to generate specific certificate (system, user, all)
  * #46 #45 : Use acme-v02 and acme-v01
  * #36 #23 : Fix php notice
  * #38 #37 : be silent if all done , add erbosity mode
  * #40 #39 : generate system certficate before user domains
  * #42 #41 : restore missing file by #30
  * #33     : Fix php warning
  * #26     : add missing build dependencies
  * #25 #24 : clean some files during build
  * #30 #29 : generate cert on sub domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camlafit camlafit camlafit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kienanstewart @camlafit