Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use fixed sed script path #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Do not use fixed sed script path #261

wants to merge 3 commits into from

Commits on Jan 25, 2024

  1. Use mktemp to get the filename for storing the templating script 

    Using a fixed string could allow for abuse by anyone who has access to /tmp.
One could place a symbolic link to any file to cause it to be overwritten
when alternc.install is run.
    @kienanstewart @camlafit
    kienanstewart authored and camlafit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    cbfbb0c View commit details
    Browse the repository at this point in the history

  2. Pass SED_SCRIPT to install.d scripts for templating action

    @kienanstewart @camlafit
    kienanstewart authored and camlafit committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ad19402 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Use sed_script during roundcube installation 

    * SED_SCRIPT is provided as second argument to all install.d/ scripts

Follow exit status as explained at https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html
    @camlafit
    camlafit committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3ea150e View commit details
    Browse the repository at this point in the history