Fix error message when deleting user in AdminService

Alovoa · Jul 17, 2021 · a64d732 · a64d732
1 parent 97b9269
commit a64d732
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/com/nonononoki/alovoa/service/AdminService.java b/src/main/java/com/nonononoki/alovoa/service/AdminService.java
@@ -213,6 +213,10 @@ public void deleteAccount(AdminAccountDeleteDto dto) throws AlovoaException {
 
 		User user = userRepo.findByEmail(dto.getEmail());
 
+		if (user == null) {
+			throw new AlovoaException("user_not_found");
+		}
+
 		if (user.isAdmin()) {
 			throw new AlovoaException("cannot_delete_admin");
 		}
@@ -226,8 +230,6 @@ public void deleteAccount(AdminAccountDeleteDto dto) throws AlovoaException {
 			userRepo.delete(userRepo.findByEmail(user.getEmail()));
 			userRepo.flush();
 		}
-
-		throw new AlovoaException("user_not_found");
 	}
 
 	private void checkRights() throws AlovoaException {