fix: update dependencies #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtyoung84
approved these changes
Apr 17, 2024
mekhlakapoor
added a commit
that referenced
this pull request
Apr 19, 2024
* Bug 78 bool (#100) * updates readme * defaults boolean vals to false (so checkbox works) * Bug 78 bool (#101) * updates readme * defaults boolean vals to false (so checkbox works) * recursive method to replace boolean widgets, need to fix * - * manual ui schema in progress * ephys ui schema * fix ephys ui schema * endline * small fix * Bug 78 bool widget (#103) * feat: adds rjsf material ui package * feat: adds custom checkbox for booleans --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> * removes override --------- Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> * hot fix (#106) * fix: filters version list by schema type (#116) * Feat 110 remove schemas (#115) * Deploy to prod (#107) * Bug 78 bool (#100) * updates readme * defaults boolean vals to false (so checkbox works) * Bug 78 bool (#101) * updates readme * defaults boolean vals to false (so checkbox works) * recursive method to replace boolean widgets, need to fix * - * manual ui schema in progress * ephys ui schema * fix ephys ui schema * endline * small fix * Bug 78 bool widget (#103) * feat: adds rjsf material ui package * feat: adds custom checkbox for booleans --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> * removes override --------- Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> * hot fix (#106) --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> * version bump [skip actions] * removes ephys, ophys, behavior rigs & sessions * off dev * schemas filtered with env variable * env template --------- Co-authored-by: Yosef Bedaso <20714699+yosefmaru@users.noreply.github.com> Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Renders dictionaries (#118) * recursion, unit test, additional properties * fix import * docstring * Sort schema versions dropdown by lastest-first semantic version * Add sample schema list and sorted version list for unit tests * Add unit tests for Dropdowns and sorted schema version * Feat 117: Sort schema versions list in dropdown by lastest-first semantic version (#123) * Sort schema versions dropdown by lastest-first semantic version * Add sample schema list and sorted version list for unit tests * Add unit tests for Dropdowns and sorted schema version * Fix 119: Fix pre-process and render issues and improve UI (#127) * add error handling for preProcessSchema() andfetchAndSetSchema() * handle prop.default is null * improve App component UI and styling * refactor Dropdowns to Toolbar, add styling, disable version dropdown and upload btn on default * add default titles to dropdown of allowed types/ subschemas * add react-toastify for notifications * handle schema version changes from App component (#130) * Feat 27: Add linter and unit test frameworks (#133) * add ESLint with React plugin, JS Standard style guide * add unit test commands * add current coverage as test coverageThreshold * linter auto-fix styling issues * fix linting issues (imports, React in scope, camelCase) * add propTypes to resolve prop validation linting issues * Feat 27: Add linter and unit test frameworks * finish merge * Fix 131: Enforce re-render and handle errors in `RenderForm` component (#142) * Add ErrorBoundary for RenderForm component * use selectedSchemaPath as key to re-render RenderForm component * create unit test suite for App component * Fix 132: Update schema filtering and validation (#143) * parse and validate schema type, version to fix filter logic * create unit tests for parseAndFilterSchemas() * replace selectedSchemaVersion with unique selectedSchemaPath * Feat 68: Add border-left css for nested form fieldsets (#147) * Fix 139: Enable discriminator support in validator and fix validation errors (#151) * enable discriminator validation in ajv validator * remove extra formData on changes to seleciton/ discriminator * update empty object check * update unit tests * fix redundant lines * Fix 108: Error handling, validation, and UI fixes for Autofill feature (#154) * add error handling and file type validation for file upload * validate uploaded schema type, version with possible schemas * clear autofilled formData after change schema * allow autofill with any schema type * refactor RehydrateForm.js from component to util function * success toast to indicate autofill complete, fix button focus * code cleanup * update unit tests for autofill feature changes * update test coverage thresholds * Fix 102: Fix nested constants render issues (#157) * fix rendering of nested literals/ consts * revert other widgets to material-ui to keep label * Enforce const values set to formData, enforce null consts as null strings * update @rjsf/core * useLayoutEffect in custom widget to sync changes on screen * explicityly set missing type for all consts, check default value is correct * update unit tests to check consts preprocessed and rendered correctly * update docstrings * update docstrings * Fix: Render null consts as nullable strings and update CustomTextWidget (#161) * update CustomTextWidget effect to only run when necessary * render null consts as nullable strings with CustomTextWidget * Feat 149: Add Help button and popup UI (#166) * add Help popup with link to repo and tips * add unit tests * add aind-data-schema readthedocs link to help ui * resolve conflicts * fix: update dependencies (#168) * fix: npm audit fix * fix: remove unused dependencies * fix: add missing dependencies * fix: npm update --save * fix: add overrides for react-scripts dependencies (#169) --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> Co-authored-by: Yosef Bedaso <20714699+yosefmaru@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
mekhlakapoor
added a commit
that referenced
this pull request
May 3, 2024
* Bug 78 bool (#100) * updates readme * defaults boolean vals to false (so checkbox works) * Bug 78 bool (#101) * updates readme * defaults boolean vals to false (so checkbox works) * recursive method to replace boolean widgets, need to fix * - * manual ui schema in progress * ephys ui schema * fix ephys ui schema * endline * small fix * Bug 78 bool widget (#103) * feat: adds rjsf material ui package * feat: adds custom checkbox for booleans --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> * removes override --------- Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> * hot fix (#106) * fix: filters version list by schema type (#116) * Feat 110 remove schemas (#115) * Deploy to prod (#107) * Bug 78 bool (#100) * updates readme * defaults boolean vals to false (so checkbox works) * Bug 78 bool (#101) * updates readme * defaults boolean vals to false (so checkbox works) * recursive method to replace boolean widgets, need to fix * - * manual ui schema in progress * ephys ui schema * fix ephys ui schema * endline * small fix * Bug 78 bool widget (#103) * feat: adds rjsf material ui package * feat: adds custom checkbox for booleans --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> * removes override --------- Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> * hot fix (#106) --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> * version bump [skip actions] * removes ephys, ophys, behavior rigs & sessions * off dev * schemas filtered with env variable * env template --------- Co-authored-by: Yosef Bedaso <20714699+yosefmaru@users.noreply.github.com> Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Renders dictionaries (#118) * recursion, unit test, additional properties * fix import * docstring * Sort schema versions dropdown by lastest-first semantic version * Add sample schema list and sorted version list for unit tests * Add unit tests for Dropdowns and sorted schema version * Feat 117: Sort schema versions list in dropdown by lastest-first semantic version (#123) * Sort schema versions dropdown by lastest-first semantic version * Add sample schema list and sorted version list for unit tests * Add unit tests for Dropdowns and sorted schema version * Fix 119: Fix pre-process and render issues and improve UI (#127) * add error handling for preProcessSchema() andfetchAndSetSchema() * handle prop.default is null * improve App component UI and styling * refactor Dropdowns to Toolbar, add styling, disable version dropdown and upload btn on default * add default titles to dropdown of allowed types/ subschemas * add react-toastify for notifications * handle schema version changes from App component (#130) * Feat 27: Add linter and unit test frameworks (#133) * add ESLint with React plugin, JS Standard style guide * add unit test commands * add current coverage as test coverageThreshold * linter auto-fix styling issues * fix linting issues (imports, React in scope, camelCase) * add propTypes to resolve prop validation linting issues * Feat 27: Add linter and unit test frameworks * finish merge * Fix 131: Enforce re-render and handle errors in `RenderForm` component (#142) * Add ErrorBoundary for RenderForm component * use selectedSchemaPath as key to re-render RenderForm component * create unit test suite for App component * Fix 132: Update schema filtering and validation (#143) * parse and validate schema type, version to fix filter logic * create unit tests for parseAndFilterSchemas() * replace selectedSchemaVersion with unique selectedSchemaPath * Feat 68: Add border-left css for nested form fieldsets (#147) * Fix 139: Enable discriminator support in validator and fix validation errors (#151) * enable discriminator validation in ajv validator * remove extra formData on changes to seleciton/ discriminator * update empty object check * update unit tests * fix redundant lines * Fix 108: Error handling, validation, and UI fixes for Autofill feature (#154) * add error handling and file type validation for file upload * validate uploaded schema type, version with possible schemas * clear autofilled formData after change schema * allow autofill with any schema type * refactor RehydrateForm.js from component to util function * success toast to indicate autofill complete, fix button focus * code cleanup * update unit tests for autofill feature changes * update test coverage thresholds * Fix 102: Fix nested constants render issues (#157) * fix rendering of nested literals/ consts * revert other widgets to material-ui to keep label * Enforce const values set to formData, enforce null consts as null strings * update @rjsf/core * useLayoutEffect in custom widget to sync changes on screen * explicityly set missing type for all consts, check default value is correct * update unit tests to check consts preprocessed and rendered correctly * update docstrings * update docstrings * Fix: Render null consts as nullable strings and update CustomTextWidget (#161) * update CustomTextWidget effect to only run when necessary * render null consts as nullable strings with CustomTextWidget * Feat 149: Add Help button and popup UI (#166) * add Help popup with link to repo and tips * add unit tests * add aind-data-schema readthedocs link to help ui * resolve conflicts * fix: update dependencies (#168) * fix: npm audit fix * fix: remove unused dependencies * fix: add missing dependencies * fix: npm update --save * fix: add overrides for react-scripts dependencies (#169) * fix: inputs performance, remove `liveOmit` and add `omitExtraDataOnBlur` (#171) * fix: remove liveOmit from RJSF form due to perf issues * fix: add custom omitExtraDataOnBlur * refactor: move saveToJSONFile to fileUtils * test: add unit tests for RenderForm * feat: scrollable form with pinned toolbars (#172) * feat: css for scrollable form * feat: add focusOnFirstError to scroll to error after validation * feat: update Toolbar css * feat: add Submit, Validate, Reset btns in Form toolbar * remove reset btn * test: add unit test for validate form --------- Co-authored-by: Mekhla Kapoor <54870020+mekhlakapoor@users.noreply.github.com> Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com> Co-authored-by: Yosef Bedaso <20714699+yosefmaru@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138, also closes #104
npm auditreport. Updated all minor versions, removed unused dependencies, and added missing dependenciesBefore:
npm audit --omit=dev(same as runningnpm audit --production): 9 moderate vulnerabilitiesnpm audit: 21 vulnerabilitiesNow:
npm audit --omit=dev: 0 vulnerabilitiesnpm audit: 8 vulnerabilities. All related to transient dependencies forreact-scripts, can be ignored.npm auditsays I have a vulnerability in react-scripts! facebook/create-react-app#11174