Skip to content

Commit

Permalink
Merge pull request #193 from AllenInstitute/dev
Browse files Browse the repository at this point in the history
Dev
  • Loading branch information
rcpeene committed Apr 20, 2023
2 parents 8ff3811 + cbe1711 commit 753789b
Show file tree
Hide file tree
Showing 23 changed files with 1,994 additions and 1,653 deletions.
3 changes: 0 additions & 3 deletions .binder/postBuild

This file was deleted.

3 changes: 1 addition & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ jobs:
pip install jupyter
pip install -U jupyter-book
pip install nbmake
pip install pytest-xdist
- name: Testing notebooks
run: pytest --nbmake --nbmake-timeout=5000 -n=auto "./docs"
run: pytest --nbmake --nbmake-timeout=5000 "./docs"

- name: Build Jupyter book
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
pip install jupyter
pip install -U jupyter-book
pip install nbmake
pip install pytest-xdist
- name: Getting changed files
id: changed_files
Expand All @@ -41,5 +40,6 @@ jobs:
filter: "*.ipynb"

- name: Testing notebooks
run: pytest --nbmake --nbmake-timeout=5000 -n=auto ${{ steps.changed_files.outputs.added_modified }}
if: ${{ steps.changed_files.outputs.added_modified }} != ""
run: pytest --nbmake --nbmake-timeout=5000 ${{ steps.changed_files.outputs.added_modified }}

File renamed without changes.
43 changes: 29 additions & 14 deletions docs/basics/download_nwb.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,20 @@
{
"cell_type": "code",
"execution_count": 1,
"id": "014235db",
"metadata": {},
"outputs": [],
"source": [
"### if running on Google Colab, run this cell once, then restart the runtime and run the rest of the notebook\n",
"import os\n",
"if \"COLAB_GPU\" in os.environ:\n",
" !wget https://raw.githubusercontent.com/AllenInstitute/openscope_databook/main/requirements.txt\n",
" %pip install -r requirements.txt --user"
]
},
{
"cell_type": "code",
"execution_count": 2,
"id": "8f34eecf",
"metadata": {},
"outputs": [],
Expand All @@ -38,7 +52,7 @@
},
{
"cell_type": "code",
"execution_count": 2,
"execution_count": 3,
"id": "67536d37",
"metadata": {},
"outputs": [],
Expand All @@ -51,17 +65,10 @@
},
{
"cell_type": "code",
"execution_count": 3,
"execution_count": 4,
"id": "a309c067",
"metadata": {},
"outputs": [
{
"name": "stderr",
"output_type": "stream",
"text": [
"A newer version (0.46.6) of dandi/dandi-cli is available. You are using 0.46.3\n"
]
},
{
"name": "stdout",
"output_type": "stream",
Expand Down Expand Up @@ -91,7 +98,7 @@
},
{
"cell_type": "code",
"execution_count": 4,
"execution_count": 5,
"id": "fe9aa40c",
"metadata": {},
"outputs": [],
Expand All @@ -101,7 +108,7 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 6,
"id": "c176c129",
"metadata": {},
"outputs": [],
Expand All @@ -112,7 +119,7 @@
},
{
"cell_type": "code",
"execution_count": 5,
"execution_count": 7,
"id": "a110beeb",
"metadata": {},
"outputs": [
Expand Down Expand Up @@ -143,10 +150,18 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 8,
"id": "1c42049e",
"metadata": {},
"outputs": [],
"outputs": [
{
"name": "stdout",
"output_type": "stream",
"text": [
"Downloaded directory to ./000021\n"
]
}
],
"source": [
"# patience isn't just a virtue, it's a requirement\n",
"my_dandiset.download_directory(\"./\", f\"{download_loc}/{dandiset_id}\")\n",
Expand Down

0 comments on commit 753789b

Please sign in to comment.