Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added long press event & fixed memory leak #177

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JonasGessner
Copy link

No description provided.

@AliSoftware
Copy link
Owner

Nice addition but two questions:

  • Why the enabled=NO then enabled=YES here?
  • Couldn't we mutualize some code about detection of the link under the tapped point between the tapGR and the longPressGR ?

A bit busy so won't have time to review it all until at least next WE anyway, please be patient ;)

@JonasGessner
Copy link
Author

The enabled part is unnecessary. It is used to cancel a gesture recognizer but in this case it doesn't need to be cancelled.

About mutualizing code: Some mutualization would be possible but we are really just talking about a few lines of code so I think the code is fine like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants