Smoothing interaction between VarSets and actual sets and functions #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kris-brown
approved these changes
Apr 22, 2024
|
@epatters Could you merge this and do a patch release? |
epatters
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Though the additions are simple, if they are to be part of the public API of Catlab, then they should have tests, which is what will ensure that they remain stable over time. I think the important thing to add tests for is the conversion between SetOb/FinSets and VarSets.
epatters
changed the title
epatters
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes below are to enable smoother data migrations of acsets with some
AttrVarattribute values as requested here: AlgebraicJulia/DataMigrations.jl#159