Feature/fix issue 566 #567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to avoid replacing the ootb file. This will fix problems like issue 566, where the original properties are simply removed by the file replacement.
… archetype, some of it's properties have to be filtered by Maven. So the filesets were changed accordingly.
… in order to avoid replacing the ootb file. This will fix problems like issue 566, where the original properties are simply removed by the file replacement.
… archetype, some of it's properties have to be filtered by Maven. So the filesets were changed accordingly.
nbarithel
reviewed
May 4, 2019
.../resources/archetype-resources/__rootArtifactId__-platform-docker/src/main/docker/Dockerfile
Outdated
Show resolved
Hide resolved
nbarithel
reviewed
May 4, 2019
...sco-platform-jar-archetype/src/main/resources/archetype-resources/src/main/docker/Dockerfile
Outdated
Show resolved
Hide resolved
Duplicated lines removal
Duplicated lines removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #566 by avoiding having the alfresco-global.properties replaced by the one defined in the project.
The "new" way to define custom alfresco-global.properties is by adding them into the Dockerfile file.
I guess the documentation will have to be reviewed to reflect this change, as there won't be an alfresco-global.properties anymore to be changed in order to have the project executed by maven.