New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-7381][ADF] Break DataTable dependency on Material Module #9657
Open
tamaragruszka
wants to merge
14
commits into
develop
Choose a base branch
from
ACS-7381-ADF-Break-DataTable-dependency-on-Material-Module
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ACS-7381][ADF] Break DataTable dependency on Material Module #9657
tamaragruszka
wants to merge
14
commits into
develop
from
ACS-7381-ADF-Break-DataTable-dependency-on-Material-Module
+1,127
−976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaragruszka
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
May 7, 2024 15:07
tamaragruszka
requested review from
AleksanderSklorz,
DaryaBalvanovich,
DenysVuika,
g-jaskowski,
jacekpluta,
MichalKinas and
tomson7777
May 7, 2024 15:07
DenysVuika
reviewed
May 7, 2024
lib/content-services/src/lib/document-list/components/document-list.component.spec.ts
Show resolved
Hide resolved
DenysVuika
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff, thanks
g-jaskowski
approved these changes
May 9, 2024
…n-Material-Module
…n-Material-Module
…n-Material-Module
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-7381
What is the new behaviour?
All components and directives of datatable are standalone
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: