HXCS-3659 copy feature-flags lib #9655

wideLandscape · 2024-05-07T12:27:27Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines

Tests for the changes have been added (for bug fixes / features)

Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

Bugfix

Feature

Code style update (formatting, local variables)

Refactoring (no functional changes, no api changes)

Build related changes

Documentation

Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/HXCS-3659

What is the new behaviour?

https://hyland.atlassian.net/browse/HXCS-3659

Does this PR introduce a breaking change? (check one with "x")

Yes

No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

CLAassistant · 2024-05-07T12:27:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Adriano Costa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

lib/core/feature-flags/src/lib/components/feature-overridability-indicator.component.ts

DenysVuika · 2024-05-07T12:49:40Z

@wideLandscape the corresponding JIRA is empty

cspell.json

lib/core/feature-flags/src/lib/services/storage-features.service.ts

lib/core/feature-flags/src/lib/components/flags/flags.component.html

wideLandscape · 2024-05-07T13:43:52Z

@wideLandscape the corresponding JIRA is empty

Sorry, I forgot to click the save button 😅 you should see the description now

lib/core/feature-flags/src/lib/services/debug-features.service.ts

lib/core/feature-flags/src/lib/services/dummy-features.service.ts

lib/core/feature-flags/src/lib/providers/debug-feature-flags.provider.ts

lib/core/feature-flags/src/lib/providers/dummy-feature-flags.provider.ts

lib/core/feature-flags/src/lib/services/storage-features.service.ts

lib/core/feature-flags/src/lib/services/flagset.parser.ts

DenysVuika · 2024-05-07T13:51:15Z

Please don't forget to provide the documentation and tests for the feature

wideLandscape · 2024-05-08T07:09:41Z

lib/core/feature-flags/src/lib/directives/features.directive.ts

+
+@Directive({
+    /* eslint-disable-next-line @angular-eslint/directive-selector */
+    selector: '[forFeatures]',


Should I rename forFeatures and notForFeatures directives
adf-for-feature and adf-not-for-features?
@DenysVuika

I'm not sure about this, what do you think @DenysVuika . Sometimes the ADF prefix for directives is more bothering then helping, I think this is a similar case.
From my side, I would leave it as they are, since this way they are quite easy to read and self-explanatory.

can be adfForFeatures, similar to how we have all cdkFeature directives from material

wideLandscape · 2024-05-10T11:05:23Z

lib/core/feature-flags/src/lib/services/storage-features.service.spec.ts

+
+            storageFeaturesService.mergeFlags(newFlags);
+
+            expect(storageFeaturesService.getFlagsSnapshot()).toEqual({


to be honest I didn't fully grasp how the method works, I did make it fail to have the expected result and edit the test accordingly.

wideLandscape · 2024-05-10T11:26:43Z

I have added the unit tests, will update readme with further info asap.
I did my best to cover the most relevant code of the lib, sometimes I had to make tests fail to have the expected result as I didn't fully understand some methods.
I'd like to merge it by eod if possible, as the goal of the PR was to copy the lib from a repo to another, and the code is already running in prod (from the hxp-frontend-apps repo).
thanks
@popovicsandras @DenysVuika

lib/core/feature-flags/src/lib/components/feature-flags-wrapper.ts

lib/core/feature-flags/src/lib/components/feature-override-indicator.component.ts

sonarcloud · 2024-05-22T08:11:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

@input

* HXCS-3659 copy feature-flags lib * HXCS-3659 remove hxps reference * HXCS-3659 update component selectors * HXCS-3659 replace word overridability with override * HXCS-3659 remove commented/dead code * HXCS-3659 rename files * HXCS-3659 fix imports after renaming files * HXCS-3659 update names to not refer ng 14 * HXCS-3659 update license header * HXCS-3659 remove unused param * HXCS-3659 test StorageFesturesService * HXCS-3659 test DummyFesturesService * HXCS-3659 test DebugFeaturesService in debug mode * HXCS-3659 test DebugFeaturesService in debug mode * HXCS-3659 test DebugFeaturesService not in debug mode * HXCS-3659 test FlagSetParser * HXCS-3659 test feature flags directives * HXCS-3659 test flags component * HXCS-3659 update readme * HXCS-3659 link docs into readme * HXCS-3659 update adf-feature-flags-wrapper css rules * HXCS-3659 update Directive selectors * HXCS-3659 add i18n * HXCS-3659 update FlagsComponent css * HXCS-3659 update directives @input property names * HXCS-3659 provides guards in the root * HXCS-3659 remove deprecated method getFlagsSnapshot --------- Co-authored-by: Adriano Costa <Adriano.Costa@hyland.comgit>