Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6819][FE] Document List View Header - move and resize columns icons are overlapping #9388

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tamaragruszka
Copy link
Contributor

@tamaragruszka tamaragruszka commented Feb 27, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Header icons move and resize are overlapping
ACS-6819

What is the new behaviour?
Header move and resize aren't overlapping

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

If you check files for specific library then "Modified" and "Modified by" headers are a bit not aligned in comparison with content of these columns.
image

@AleksanderSklorz
Copy link
Contributor

Please update PR's title with jira number:
image

@AleksanderSklorz
Copy link
Contributor

Tags column seems not aligned as well:
image

@AleksanderSklorz
Copy link
Contributor

Columns in Favorite libraries are not aligned:
image

@AleksanderSklorz
Copy link
Contributor

Columns are not aligned in Favorites page:
image

@AleksanderSklorz
Copy link
Contributor

the same for Trash:
image

@AleksanderSklorz
Copy link
Contributor

same for personal files, some columns are not aligned properly:
image

@AleksanderSklorz
Copy link
Contributor

the same for Tasks:
image

@AleksanderSklorz
Copy link
Contributor

@tamaragruszka please go through all lists and correct where needed. I posted here only couple of examples.

@tamaragruszka tamaragruszka changed the title [FE] Document List View Header - move and resize columns icons are overlapping [ACS-6819][FE] Document List View Header - move and resize columns icons are overlapping Feb 28, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants