[AAE-20109] Move alfresco js-API and alfrescoapi service out from the core #9317
+1,771
−954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
from
badf998
to
7aa8249
Compare
|
@eromano I rebased the PR |
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
3 times, most recently
from
2cfe5ee
to
b227537
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
2 times, most recently
from
176ea94
to
1c6a364
Compare
|
Added migration schematics for Steps how to test it:
In case you got an error with versions, please change version in angular.json to |
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
3 times, most recently
from
849f6ac
to
6d30a95
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
4 times, most recently
from
1f3cd6c
to
f18ba12
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
3 times, most recently
from
b47d6ef
to
899dbfb
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
3 times, most recently
from
8d4ae82
to
aee39f2
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
from
aee39f2
to
80212fd
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
8 times, most recently
from
f386255
to
0213487
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
3 times, most recently
from
2b2b3d9
to
54097e1
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
from
54097e1
to
2329f88
Compare
BSekula
reviewed
May 23, 2024
| run: | | ||
| set -u; | ||
| ./scripts/update-version.sh -gnu || exit 1; | ||
| - name: Set migrations |
There was a problem hiding this comment.
Here we are setting migration version to e.g. 7.9.0-1234567890 (current release version) in lib/core/schematics/migrations/collection.json
BSekula
reviewed
May 23, 2024
| "schematics": { | ||
| "move-out-alfresco-api": { | ||
| "description": "Update alfresco-api imports", | ||
| "version": "7.0.0", |
There was a problem hiding this comment.
Versions are going to be changed by CI to current release version, so repos can be updated it like:
npx nx@17.0.2 migrate @alfresco/adf-core@6.10.0-9192302350
BSekula
reviewed
May 23, 2024
| { | ||
| name: 'move-out-alfresco-api', | ||
| allowedVersionScope: '<=7.0.0' | ||
| } |
There was a problem hiding this comment.
Here we are setting migration version to current released version e.g. 6.9.0-1234566, until it satisfy the allowedVersionCope
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
2 times, most recently
from
ffac124
to
c4df262
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
from
c4df262
to
8d74831
Compare
BSekula
force-pushed
the
dev-eromano-AAE-12502
branch
from
8d74831
to
1deee97
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-20109
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: