Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2621 Generate documentation website with jekyll #1144

Merged
merged 34 commits into from May 13, 2024
Merged

OPSEXP-2621 Generate documentation website with jekyll #1144

merged 34 commits into from May 13, 2024

Conversation

pmacius
Copy link
Contributor

@pmacius pmacius commented May 9, 2024

@pmacius pmacius requested review from alxgomz and gionn May 9, 2024 16:38
gionn
gionn reviewed May 10, 2024
View reviewed changes
docs/Gemfile.lock Outdated Show resolved Hide resolved
docs/docker-compose/README.md Outdated Show resolved Hide resolved
_config.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Show resolved Hide resolved
@pmacius pmacius marked this pull request as ready for review May 13, 2024 07:44
gionn
gionn reviewed May 13, 2024
View reviewed changes
.github/workflows/docs.yml Outdated Show resolved Hide resolved
gionn
gionn reviewed May 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
docs/docker-compose/README.md Outdated Show resolved Hide resolved
docs/helm/README.md Outdated Show resolved Hide resolved
docs/helm/desktop-deployment.md Outdated Show resolved Hide resolved
docs/helm/eks-deployment.md Outdated Show resolved Hide resolved
docs/helm/eks-deployment.md Outdated Show resolved Hide resolved
gionn
gionn reviewed May 13, 2024
View reviewed changes
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@pmacius pmacius requested a review from gionn May 13, 2024 11:22
gionn
gionn reviewed May 13, 2024
View reviewed changes
docs/index.md Show resolved Hide resolved
@pmacius pmacius requested a review from gionn May 13, 2024 13:39
alxgomz
alxgomz previously approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the splitting between examples and guides 👍

gionn
gionn requested changes May 13, 2024
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to enable mermaid rendering
https://just-the-docs.com/docs/configuration/#mermaid-diagrams

docs/helm/README.md Show resolved Hide resolved
@pmacius @gionn
Update docs/helm/README.md
c1019e7 
Co-authored-by: Giovanni Toraldo <71768+gionn@users.noreply.github.com>
@pmacius pmacius requested review from gionn and alxgomz May 13, 2024 15:33
@pmacius
Copy link
Contributor Author

pmacius commented May 13, 2024

image

@pmacius pmacius merged commit 05e08da into master May 13, 2024
18 checks passed
@pmacius pmacius deleted the OPSEXP-2621-doc branch May 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gionn gionn gionn approved these changes

@alxgomz alxgomz Awaiting requested review from alxgomz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmacius @gionn @alxgomz