Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tap_action support #668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codemunkie15
Copy link

@codemunkie15 codemunkie15 commented Mar 13, 2024

Added tap_action support using the below method:

https://developers.home-assistant.io/blog/2023/07/07/action-event-custom-cards/

I have not implemented hold_action or double_tap_action because they interfere with the video player and need more thorough investigation.

Note that on touchscreen devices (mobile/tablet) you have to set ui: true for tap_action to work otherwise the html5 video controls swallow the click events. If you don't want to see the custom UI like me, you can easily hide it with a style:

style: ".ui { display: none }"

@gogades
Copy link

gogades commented Mar 29, 2024

I tested this PR on my install and it works great 👍

@AlexxIT
Copy link
Owner

AlexxIT commented Apr 7, 2024

Thanks. This really works for PC, but I don't like idea of different behaviour for PC and Mobile.
Maybe this should work only for custom UI.

@codemunkie15
Copy link
Author

Thanks. This really works for PC, but I don't like idea of different behaviour for PC and Mobile. Maybe this should work only for custom UI.

That would be fine for me. Let me know what you decide and I can update the PR. Should I also add the changes to the documentation, or do you prefer to do that?

@mbrevda
Copy link

mbrevda commented Apr 25, 2024

will this allow for showing the video in fullscreen with a single tap?

@codemunkie15
Copy link
Author

will this allow for showing the video in fullscreen with a single tap?

Yes. I use it with a fullscreen browser_mod popup with another webrtc-camera card.

@beesee78
Copy link

will this allow for showing the video in fullscreen with a single tap?

Yes. I use it with a fullscreen browser_mod popup with another webrtc-camera card.

I have a static image 99.9% of the time (updated whenever) but a button at the bottom left of my cards to go live at any point.

@jdekoven
Copy link

I'm looking for this exact thing. However, I'm not a coder so I'm not understanding. Is there some YAML here I should add to the card, or does the developer have to add as a feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants