feat: refresh card based on IDLE or STREAMING state changes #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get the idea what you want to fix. But I don't like the solution. It can have a lot of side effects. |
|
Understood, any suggestion? |
|
Maybe easiest way to change reconnect timeout via card config for this cameras. Such a thing is not difficult to implement |
|
Works for me, but would it go back to rendering the poster when the stream stops? |
|
I don't know. Haven't tested this case. Maybe something should be fixed for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cameras out there which are only streaming intermittently, rather than continuously so WebRTC custom card waits for next reconnect (0 to 30 seconds).
With this PR, webrtc will be forced to refresh itself if the underlying camera entity's state changes into IDLE or STREAMING.
IDLE and STREAMING are defined in home assistant camera entity.
https://github.com/home-assistant/core/blob/dev/homeassistant/components/camera/__init__.py#L96
Looking forward to hearing your feedback.